Discussion:
[cairo] [PATCH] Skip font-variations test for missing fonts
Uli Schlachter
2018-03-30 07:25:28 UTC
Permalink
Signed-off-by: Uli Schlachter <***@znc.in>
---
test/font-variations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/font-variations.c b/test/font-variations.c
index 204a29743..7913701b5 100644
--- a/test/font-variations.c
+++ b/test/font-variations.c
@@ -105,7 +105,7 @@ test_variation (cairo_test_context_t *ctx,
}
if (strcmp (ft_face->family_name, "Adobe Variable Font Prototype") != 0) {
cairo_test_log (ctx, "This test requires the font \"Adobe Variable Font Prototype\" (https://github.com/adobe-fonts/adobe-variable-font-prototype/releases)");
- return CAIRO_TEST_FAILURE;
+ return CAIRO_TEST_UNTESTED;
}

ret = FT_Get_MM_Var (ft_face, &ft_mm_var);
--
2.16.2
--
cairo mailing list
***@cairographics.org
https://
Bryce Harrington
2018-04-02 18:10:02 UTC
Permalink
Confirmed test suite is broken without this due to variable fonts work,
and fixed by this change.

Reviewed-by: Bryce Harrington <***@osg.samsung.com>

Landed and pushed:
To ssh://git.freedesktop.org/git/cairo
1ed124a..fba7a7c master -> master
Post by Uli Schlachter
---
test/font-variations.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/font-variations.c b/test/font-variations.c
index 204a29743..7913701b5 100644
--- a/test/font-variations.c
+++ b/test/font-variations.c
@@ -105,7 +105,7 @@ test_variation (cairo_test_context_t *ctx,
}
if (strcmp (ft_face->family_name, "Adobe Variable Font Prototype") != 0) {
cairo_test_log (ctx, "This test requires the font \"Adobe Variable Font Prototype\" (https://github.com/adobe-fonts/adobe-variable-font-prototype/releases)");
- return CAIRO_TEST_FAILURE;
+ return CAIRO_TEST_UNTESTED;
}
ret = FT_Get_MM_Var (ft_face, &ft_mm_var);
--
2.16.2
--
cairo mailing list
https://lists.cairographics.org/mailman/listinfo/cairo
--
cairo mailing list
***@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cair
Loading...